[next] Allow writing components using Typescript and provide type definitions for NcButton
#4525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
ShGKme
reviewed
Sep 14, 2023
ShGKme
reviewed
Sep 14, 2023
|
BTW currently the vue3 eslint config is a bit outdated, so there is no typescript config as for the vue2 config. So eslint fails currently. |
susnux
added
2. developing
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
from
2daf268 to
e06994e
Compare
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
from
e06994e to
265abd0
Compare
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
3 times, most recently
from
d14f470 to
1045b48
Compare
susnux
added
3. to review
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
from
1045b48 to
ed434f7
Compare
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
from
ed434f7 to
f0e9b1d
Compare
raimund-schluessler
approved these changes
Nov 1, 2023
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
2 times, most recently
from
0a260b2 to
4f07eb1
Compare
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
3 times, most recently
from
35ce4e0 to
36a8003
Compare
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
from
36a8003 to
e673896
Compare
|
Rebased and solved some issues after all components were migrated to Vue 3. So I would say this is ready for reviews :) |
ShGKme
reviewed
Dec 22, 2023
skjnldsv
approved these changes
Dec 22, 2023
raimund-schluessler
approved these changes
Dec 22, 2023
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
from
e673896 to
38b500d
Compare
ShGKme
approved these changes
Jan 9, 2024
…clarations Signed-off-by: Ferdinand Thiessen <[email protected]>
* Fix some minor issues related to stronger typing Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/next-allow-typescript-components
branch
from
38b500d to
770ed08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Add the Typescript infrastructure to write components using Typescript and migrate a first example component (
NcButton) to Typescript. The type definitions are generated and published.Todo
As discussed previously the legacy naming of our entry points (
componentsvsComponents) will lead to a crowdeddistdirectory, as Typescript uses the source naming, but our entry points use the upper case naming.Maybe we should unify those names, meaning either rename the source folder or the entry points (?)
🏁 Checklist